[Merged by Bors] - Updated syn to 2.0.3 #2702
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Razican
requested review from
jasonwilliams,
HalidOdat,
RageKnify,
raskad,
jedel1043 and
nekevss
Test262 conformance changes
|
Codecov Report
@@ Coverage Diff @@
## main #2702 +/- ##
==========================================
+ Coverage 49.31% 49.46% +0.14%
==========================================
Files 396 392 -4
Lines 39725 39605 -120
==========================================
Hits 19592 19592
+ Misses 20133 20013 -120 see 16 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
HalidOdat
approved these changes
Mar 22, 2023
jedel1043
approved these changes
Mar 22, 2023
|
bors r+ |
bors bot
pushed a commit
that referenced
this pull request
Mar 22, 2023
<!--- Thank you for contributing to Boa! Please fill out the template below, and remove or add any information as you feel necessary. ---> This Pull Request fixes/closes #2700. It updates the `syn` dependency to v2. I had to activate the "full" feature in order to make have the tuple elements available in `boa_macros/src/lib.rs` line 81. Maybe we could look for a different way of doing this (didn't spend time on it), to avoid activating all features of `syn`.
|
Pull request successfully merged into main. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request fixes/closes #2700. It updates the
syndependency to v2.I had to activate the "full" feature in order to make have the tuple elements available in
boa_macros/src/lib.rsline 81. Maybe we could look for a different way of doing this (didn't spend time on it), to avoid activating all features ofsyn.